Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go1.21.1 #524

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add go1.21.1 #524

merged 1 commit into from
Sep 18, 2023

Conversation

kotarou1192
Copy link
Contributor

@kotarou1192 kotarou1192 commented Sep 7, 2023 •
edited
Loading

Closes: #523

  • Add go1.21.1
  • go1.21 defaults to go1.21.1

@kotarou1192 kotarou1192 requested a review from a team as a code owner September 7, 2023 02:14
@kotarou1192
Copy link
Contributor Author

@joshwlewis Is it possible to be reviewed or get an advice about this please?

@BlueGhostxxx

This comment was marked as spam.

Sign in to view
@BlueGhostxxx

This comment was marked as spam.

Sign in to view
joshwlewis
joshwlewis approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@joshwlewis joshwlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@joshwlewis
Copy link
Member 

$ sbin/sync-files.sh
Getting bucket credentials
Syncing contents of s3://heroku-golang-prod/ to /Users/josh.lewis/code/heroku-buildpack-go/file-cache.
Ensuring the correct versions of all files specified in files.json
All files verified, syncing to s3

upload: ./go1.21.1.linux-amd64.tar.gz to s3://heroku-golang-prod/go1.21.1.linux-amd64.tar.gz

@joshwlewis joshwlewis merged commit 4e2436b into heroku:main Sep 18, 2023
4 checks passed
@joshwlewis joshwlewis mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwlewis joshwlewis joshwlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go 1.21.1 is released!
3 participants
@kotarou1192 @BlueGhostxxx @joshwlewis